Merged
Conversation
ChrisM-S
approved these changes
Feb 21, 2025
ChrisM-S
left a comment
ChrisM-S
left a comment
There was a problem hiding this comment.
Agree with the naming and the classifications specified
|
I'm happy with the changes to the file (so approved those) and would push the Merge button - given all green lights but I await someone saying this is the right thing to do before pushing the button. |
Member
Author
|
@ChrisM-S yes it would be to press the button now all green, then update the pinned submodule version in EPICS top. As you probabyl donlt have a checked out copy of epics top i'll push the button and do the submodule update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add emma and mux to inst list